[PATCH] D94931: [RISCV] Add attribute support for all supported extensions

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2154
+        formalArchStr = (Twine(formalArchStr) + "_zvamo0p9").str();
+      if (getFeatureBits(RISCV::FeatureStdExtZvlsseg))
+        formalArchStr = (Twine(formalArchStr) + "_zvlsseg0p9").str();
----------------
simoncook wrote:
> jrtc27 wrote:
> > Hmm how come this one is Std but too the other Zfoo's aren't?
> It seems that when Zvlsseg was added, its name was committed inconsistent with all the others. This change just uses the features as currently defined.
Yeah. Arguably the `Std` is a waste of time in all of them (both Z and single-letter), it's implied by the names. I guess someone sufficiently-motivated should clean it up one way or the other.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94931/new/

https://reviews.llvm.org/D94931