[PATCH] D94931: [RISCV] Add attribute support for all supported extensions

Simon Cook via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 18 14:24:32 PST 2021


simoncook added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2154
+        formalArchStr = (Twine(formalArchStr) + "_zvamo0p9").str();
+      if (getFeatureBits(RISCV::FeatureStdExtZvlsseg))
+        formalArchStr = (Twine(formalArchStr) + "_zvlsseg0p9").str();
----------------
jrtc27 wrote:
> Hmm how come this one is Std but too the other Zfoo's aren't?
It seems that when Zvlsseg was added, its name was committed inconsistent with all the others. This change just uses the features as currently defined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94931/new/

https://reviews.llvm.org/D94931



More information about the llvm-commits mailing list