[PATCH] D91870: [WebAssembly] Add support for table linking to wasm-ld

Mon Jan 18 07:02:40 PST 2021

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Thanks andy! Still lgtm.

I think re-using the same review makes sense (although I don't know the conventions/rules are around that).

================
Comment at: lld/test/wasm/export-table-test-2.test:1
+# RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown %p/Inputs/start.s -o %t.start.o
+# RUN: wasm-ld --export-table -o %t.wasm %t.start.o
----------------
Can we come up with a better name for this new test?   I don't have any great idea but just calling it "-test-2" doesn't seem useful.  

How about `export-table-explicit.test`?    Since this test includes and explicit declaration of the __indirect_function_table?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91870/new/

https://reviews.llvm.org/D91870