[PATCH] D91870: [WebAssembly] Add support for table linking to wasm-ld

Andy Wingo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 18 01:58:24 PST 2021


wingo requested review of this revision.
wingo added a comment.

PTAL @sbc100 -- the problem was that I had neglected to remove some special logic regarding export of the indirect function table.  Instead it's now handled in the usual way, as a flag on the symbol.

Added a test that succeeds either way with the current patch, but which starts failing once MC writes table symbols in https://reviews.llvm.org/D92215 with the older version of this patch.

Tested llvm-lit on MC, CodeGen, and LLD with this change with the whole patch series, and all pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91870/new/

https://reviews.llvm.org/D91870



More information about the llvm-commits mailing list