[PATCH] D94821: [flang][directive] Get rid of flangClassValue in TableGen

sameeran joshi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 17 22:02:09 PST 2021


sameeranjoshi added a comment.

This was a much needed change. Thank you for the refactoring.
One of the typical and most common problems was `FindClause` did not work as expected given that `CheckAllowed` was correctly defined for the clauses.

I see tests failing defined with the target mentioned inline.



================
Comment at: llvm/test/TableGen/directive2.td:17
 
 def TDLC_ClauseA : Clause<"clausea"> {
   let isImplicit = 1;
----------------
Did you check with the target `check-llvm-tablegen` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94821/new/

https://reviews.llvm.org/D94821



More information about the llvm-commits mailing list