[PATCH] D94821: [flang][directive] Get rid of flangClassValue in TableGen

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 13:01:30 PST 2021


clementval created this revision.
clementval added reviewers: sameeranjoshi, kiranchandramohan, SouraVX, kiranktp.
Herald added a reviewer: sscalpone.
Herald added a subscriber: mehdi_amini.
clementval requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, sstefan1.
Herald added a project: LLVM.

The TableGen emitter for directives has two slots for flangClass information and this was mainly
to be able to keep up with the legacy openmp parser at the time. Now that all clauses are encapsulated in 
AccClause or OmpClause, these two strings are not necessary anymore and were the the source of couple 
of problem while working with the generic structure checker for OpenMP. 
This patch remove the flangClassValue string from DirectiveBase.td and use the string flangClass as the
placeholder for the encapsulated class.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94821

Files:
  flang/lib/Lower/OpenMP.cpp
  flang/lib/Parser/openmp-parsers.cpp
  flang/lib/Parser/unparse.cpp
  flang/lib/Semantics/check-omp-structure.cpp
  llvm/include/llvm/Frontend/Directive/DirectiveBase.td
  llvm/include/llvm/Frontend/OpenACC/ACC.td
  llvm/include/llvm/Frontend/OpenMP/OMP.td
  llvm/include/llvm/TableGen/DirectiveEmitter.h
  llvm/test/TableGen/directive1.td
  llvm/test/TableGen/directive2.td
  llvm/utils/TableGen/DirectiveEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94821.317053.patch
Type: text/x-patch
Size: 28396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210115/7102eaca/attachment.bin>


More information about the llvm-commits mailing list