[PATCH] D94853: [NFC] Disallow unused prefixes under Other

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 18:43:22 PST 2021


MaskRay added inline comments.


================
Comment at: llvm/test/Other/new-pass-manager.ll:369
 ; CHECK-EXT-NEXT: Finished llvm::Function pass manager run.
+; We don't have checks for CHECK-NOEXT here, but this simplifies the test, while
+; avoiding FileCheck complaining about the unused prefix.
----------------
mtrofin wrote:
> @aeubanks : this test has CHECK-EXT asserts, but not CHECK-NOEXT. Is there a meaningful CHECK-NOEXT I could add? (other than {{.*}} )
`llvm/test/lit.cfg.py` defines `%llvmcheckext`, which expands to either CHECK-EXT or CHECK-NOEXT. You'll need two builds to verify.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94853/new/

https://reviews.llvm.org/D94853



More information about the llvm-commits mailing list