[PATCH] D94853: [NFC] Disallow unused prefixes under Other

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/test/Other/new-pass-manager.ll:369
 ; CHECK-EXT-NEXT: Finished llvm::Function pass manager run.
+; We don't have checks for CHECK-NOEXT here, but this simplifies the test, while
+; avoiding FileCheck complaining about the unused prefix.
----------------
@aeubanks : this test has CHECK-EXT asserts, but not CHECK-NOEXT. Is there a meaningful CHECK-NOEXT I could add? (other than {{.*}} )


================
Comment at: llvm/test/Other/opt-LTO-pipeline.ll:1
-; RUN: opt -enable-new-pm=0 -mtriple=x86_64-- -std-link-opts -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck --check-prefixes=CHECK,%llvmcheckext %s
+; RUN: opt -enable-new-pm=0 -mtriple=x86_64-- -std-link-opts -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK %s
 
----------------
@aeubanks : it seems this test doesn't have CHECK-EXT, not CHECK-NOEXT - OK to remove the %llvmcheckext?


================
Comment at: llvm/test/Other/print-slotindexes.ll:1
-; RUN: llc -print-after=slotindexes < %s 2>&1 | FileCheck %s --check-prefixes=ALL,SI 
-; RUN: llc -print-after=slotindexes -print-slotindexes=false < %s 2>&1 | FileCheck %s --check-prefixes=ALL,NOSI
+; RUN: llc -print-after=slotindexes < %s 2>&1 | FileCheck %s --check-prefixes=CHECK,SI 
+; RUN: llc -print-after=slotindexes -print-slotindexes=false < %s 2>&1 | FileCheck %s --check-prefixes=CHECK,NOSI
----------------
@jsji : I think s/ALL/CHECK was the intention, correct? (The test passes)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94853/new/

https://reviews.llvm.org/D94853