[PATCH] D94743: [Attributor][FIX] Do not delete non`-mustprogress` calls

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2888
+    const auto &MustProgressAA = A.getAndUpdateAAFor<AAMustProgress>(
+        *this, CallIRP, /* TrackDependence */ false);
+    if (!MustProgressAA.isAssumedMustProgress())
----------------
nikic wrote:
> Shouldn't this be checking willreturn rather than mustprogress?
Hm, willreturn is stronger, isn't it (it implies mustprogress IIRC)?
But here we also require no side-effects so they are probably equivalent.
What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94743/new/

https://reviews.llvm.org/D94743