[PATCH] D94743: [Attributor][FIX] Do not delete non`-mustprogress` calls

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 00:30:31 PST 2021


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2888
+    const auto &MustProgressAA = A.getAndUpdateAAFor<AAMustProgress>(
+        *this, CallIRP, /* TrackDependence */ false);
+    if (!MustProgressAA.isAssumedMustProgress())
----------------
Shouldn't this be checking willreturn rather than mustprogress?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94743/new/

https://reviews.llvm.org/D94743



More information about the llvm-commits mailing list