[PATCH] D94347: [WebAssembly] locals can now be indirect in DWARF

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 00:55:57 PST 2021


pfaffe added a comment.

`DW_OP_deref` loads 32bit (64bit if the address size is 8), is that what's intended here? The struct passed by value could be bigger than that, couldn't it?

Currently, `DW_OP_WASM_location` is always followed by a `DW_OP_stack_value`. Instead of emitting `DW_OP_deref`, what if you didn't emit the stack value op? `DW_OP_stack_value` indicates that the top-stack isn't an andress but is in fact the actual value. Which seems is exactly the opposite of what we need for the by-val case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94347/new/

https://reviews.llvm.org/D94347



More information about the llvm-commits mailing list