[PATCH] D94347: [WebAssembly] locals can now be indirect in DWARF

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.cpp:64
+    MachineOperand &Op1 = DBI->getOperand(1);
+    bool indirect = Op1.isImm() && Op1.getImm() == 0;
+    Op0.ChangeToTargetIndex(indirect ? llvm::WebAssembly::TI_LOCAL_INDIRECT
----------------
dschuff wrote:
> what does the immediate operand of the DBG_VALUE represent here?
it's the second operand which is typically either `0` (indirect) or `$noreg`. See use of `$noreg` here: https://llvm.org/docs/SourceLevelDebugging.html


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94347/new/

https://reviews.llvm.org/D94347