[PATCH] D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable

James Player via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 14:58:35 PST 2021


jplayer-nv updated this revision to Diff 316786.
jplayer-nv added a comment.

Added `!defined(__clang__)` conditions to `static_assert` preprocessing.  Also added large comment describing the mental gymnastics of the `OptionalStorage` specialization condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93510/new/

https://reviews.llvm.org/D93510

Files:
  llvm/include/llvm/ADT/Optional.h
  llvm/unittests/ADT/OptionalTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93510.316786.patch
Type: text/x-patch
Size: 6871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210114/b1b14b5c/attachment.bin>


More information about the llvm-commits mailing list