[PATCH] D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 12:58:51 PST 2021


aganea added inline comments.


================
Comment at: llvm/unittests/ADT/OptionalTest.cpp:416
+
+#if defined(_MSC_VER) && _MSC_VER >= 1927
+// Currently only true on recent MSVC releases.
----------------
@jplayer-nv Could you please also add `&& !defined(__clang__)` like suggested by David above? Same thing below at L464.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93510/new/

https://reviews.llvm.org/D93510



More information about the llvm-commits mailing list