[PATCH] D94470: [LSR] Don't break a critical edge if parent ends with "callbr"

Thu Jan 14 13:32:33 PST 2021

nickdesaulniers added a comment.

In D94470#2499394 <https://reviews.llvm.org/D94470#2499394>, @jyknight wrote:

>> This patch also fixes the test case in D88438 <https://reviews.llvm.org/D88438> (and D88438 <https://reviews.llvm.org/D88438> also fixes this test case).
>
> Does that other review fix this test case intrinsically -- in that this patch is //definitely// not necessary if that is committed? Or might it just be fixed by accident -- e.g. this particular test-case doesn't trigger the problem anymore, but something else might, without this patch?

>From the github links posted above; both traces from the unwind post-failed-assertion look the same.  I assume this patch terminates LoopReduce sooner than D88438 <https://reviews.llvm.org/D88438> would (though SplitCriticalEdge is called from many other passes than just LoopReduce).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94470/new/

https://reviews.llvm.org/D94470