[PATCH] D94470: [LSR] Don't break a critical edge if parent ends with "callbr"

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 13:25:28 PST 2021


jyknight added a comment.

> This patch also fixes the test case in D88438 <https://reviews.llvm.org/D88438> (and D88438 <https://reviews.llvm.org/D88438> also fixes this test case).

Does that other review fix this test case intrinsically -- in that this patch is //definitely// not necessary if that is committed? Or might it just be fixed by accident -- e.g. this particular test-case doesn't trigger the problem anymore, but something else might, without this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94470/new/

https://reviews.llvm.org/D94470



More information about the llvm-commits mailing list