[PATCH] D93485: [openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955

Thu Jan 14 08:34:18 PST 2021

clementval added a comment.

In D93485#2498333 <https://reviews.llvm.org/D93485#2498333>, @sameeranjoshi wrote:

> I couldn't understand still the rational for `*.cpp.inc` to `*.inc` for both OMP and OACC, could you please point why was that needed?

Well, when we started with the TableGen code generation we separated definition and declaration but this was not really the way to go and that's why now all code block are generated in a single file. Since this file is included in both headers and .cpp file, `.inc` is more appropriate.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93485/new/

https://reviews.llvm.org/D93485