[PATCH] D93485: [openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955

sameeran joshi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 07:55:12 PST 2021


sameeranjoshi accepted this revision.
sameeranjoshi added a comment.
This revision is now accepted and ready to land.

Thank you for the patch.
It was pending since many days.
The changes look good to me from the matching point w.r.t the linked patch.
I couldn't understand still the rational for `*.cpp.inc` to `*.inc` for both OMP and OACC, could you please point why was that needed?
Thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93485/new/

https://reviews.llvm.org/D93485



More information about the llvm-commits mailing list