[PATCH] D94568: [RISCV] Rename pcnt->cpop to match 0.93 bitmanip spec.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 05:25:28 PST 2021


asb added a comment.

In D94568#2495052 <https://reviews.llvm.org/D94568#2495052>, @kito-cheng wrote:

> RVB 0.93 is an awkward version to me, there is mnemonic conflict which is not resolved during release process since it's kind of too rush, the conflict one is bext in zbe and zbs...
>
> However it's also a milestone for B-ext, since this version claim zba, zbb and zbc is frozen, maybe those 3 sub-ext. could be removed from the umbrella of `-menable-experimental-extension` ?
>
> @asb What do you think about this?

In terms of handling the 0.92=>0.93 switchover I think it would be better to land 0.93 in one go if feasible (whether that's a single patch or a single series of patches that are committed all together). Given we're behind an experimental feature flag anyway we have more flexibility than we would otherwise, but being in some in-between state won't be useful for many people.

For Zba/Zbb/Zbc, the language is "the extensions are expected to be unchanged in the official version." which is somewhat weaker than those sub-extensions being frozen, especially given it still needs to go through ratification. It feels early to me to remove the experimental feature flag unless there's some stronger statement elsewhere about these specs not changing in future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94568/new/

https://reviews.llvm.org/D94568



More information about the llvm-commits mailing list