[PATCH] D94568: [RISCV] Rename pcnt->cpop to match 0.93 bitmanip spec.

Simon Cook via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 13 02:41:18 PST 2021


simoncook added a comment.

In D94568#2495052 <https://reviews.llvm.org/D94568#2495052>, @kito-cheng wrote:

> RVB 0.93 is an awkward version to me, there is mnemonic conflict which is not resolved during release process since it's kind of too rush, the conflict one is bext in zbe and zbs...
>
> However it's also a milestone for B-ext, since this version claim zba, zbb and zbc is frozen, maybe those 3 sub-ext. could be removed from the umbrella of `-menable-experimental-extension` ?
>
> @asb What do you think about this?

I think it only makes sense to mark it as not experimental when the sub extensions get marked as frozen in the main isa spec document.

As far as this change is concerned, it looks good to me, but I think this should only land when all parts are 0.93 compatible. Given we support this extension via clang and require 0.92 to be set, I'm reluctant to have the compiler in a half-0.92/half-0.93 state, especially so close to LLVM 12 branching.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94568/new/

https://reviews.llvm.org/D94568



More information about the llvm-commits mailing list