[PATCH] D94667: [llvm-nm] - Move MachO specific logic out from the dumpSymbolNamesFromObject(). NFC.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1689
+
 static void dumpSymbolNamesFromObject(SymbolicFile &Obj, bool printName,
                                       StringRef ArchiveName = {},
----------------
jhenderson wrote:
> Is everything in this function essentially identical to what was there before (barring the new call)? For some reason, Phabricator isn't showing the "moved" marker, so I can't tell.
Yes. 

Previously we had

```
if (MachO && !NoDyldInfo) {
  <logic>
}
```

and now we have:


```
if (MachO && !NoDyldInfo)
  dumpSymbolsFromDLInfoMachO(*MachO);
```

It is the only difference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94667/new/

https://reviews.llvm.org/D94667