[PATCH] D94667: [llvm-nm] - Move MachO specific logic out from the dumpSymbolNamesFromObject(). NFC.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1320
+          StringRef SectionName = StringRef();
+          for (const SectionRef &Section : MachO.sections()) {
+            S.NSect++;
----------------
Whilst you're here, you could get rid of the unnecessary `const &` here, if you want.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1689
+
 static void dumpSymbolNamesFromObject(SymbolicFile &Obj, bool printName,
                                       StringRef ArchiveName = {},
----------------
Is everything in this function essentially identical to what was there before (barring the new call)? For some reason, Phabricator isn't showing the "moved" marker, so I can't tell.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94667/new/

https://reviews.llvm.org/D94667