[PATCH] D94416: [PM] Avoid duplicates in the Used/Preserved/Required sets

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Thanks for doing the timings. The patch seems reasonable to me. I'll approve it but it would be great if you could find at least one other reviewer to take a look too.

An alternative implementation would be to use SetVector instead of SmallVector for each of the Required, RequiredTransitive, Preserved and Used sets.

Incidentally I tried a similar kind of optimisation here: https://reviews.llvm.org/differential/diff/316602/
It's still work in progress because (a) I still don't fully understand setLastUser and (b) I haven't done any performance measurements on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94416/new/

https://reviews.llvm.org/D94416