[PATCH] D94125: [Attributor] Derive `willreturn` based on `mustprogress`

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 07:20:14 PST 2021


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2298
+
+    if ((!getAnchorScope() || !getAnchorScope()->doesNotAccessMemory()) &&
+        (!getAssociatedFunction() ||
----------------
Do we have to also ensure that the function is `nounwind`? In case of an exception, we would return to the closest exception handler and not return to a point in the existing call stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94125/new/

https://reviews.llvm.org/D94125



More information about the llvm-commits mailing list