[PATCH] D90328: Eliminates dead store of an exisiting value

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 316512.
fhahn edited the summary of this revision.
fhahn added a comment.

In D90328#2489933 <https://reviews.llvm.org/D90328#2489933>, @dmccrevan wrote:

> In D90328#2484275 <https://reviews.llvm.org/D90328#2484275>, @fhahn wrote:
>
>> reverse ping.
>>
>> I think this is almost ready, it would be great to get the last remaining comments with respect to wording & tests wrapped up.
>>
>> If you won't be able to follow up on this, it would be great if you could let us know, so potentially someone else could pick it up.
>
> Sorry, still in a busy time.
>
> I switched the name of the function to `eliminateRedundantStoresOfExisitingValues`. When I reverted my changes in some of the test files, one test now fails unexpectedly. The only reason those changed was because I ran that python script to update the tests.
>
> For the additional tests, if someone else would like to pick that up, I am more than happy to go with that. I am not as well versed with my LLVM IR as many of you are :-).

I precommitted additional tests in 6077d55381a6aa3e947ef7abdc36a7515c598c8a <https://reviews.llvm.org/rG6077d55381a6aa3e947ef7abdc36a7515c598c8a>, including changes to update some of the existing tests so the new optimization does not trigger.

> Sorry about the slowness of this. I was planning on having it wrapped up weeks ago.

No worries, thanks for all the work on this so far. I think this needs an additional check for self-reads; I think the memmoves in llvm/test/Transforms/DeadStoreElimination/MSSA/simple.ll should not be removed. I'll take a look at that tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90328/new/

https://reviews.llvm.org/D90328

Files:
  llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
  llvm/test/Transforms/DeadStoreElimination/MSSA/simple.ll
  llvm/test/Transforms/DeadStoreElimination/MSSA/stores-of-existing-values.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90328.316512.patch
Type: text/x-patch
Size: 4698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210113/b886e942/attachment.bin>