[PATCH] D90328: Eliminates dead store of an exisiting value

Daniel McCrevan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 05:19:50 PST 2021


dmccrevan added a comment.

In D90328#2484275 <https://reviews.llvm.org/D90328#2484275>, @fhahn wrote:

> reverse ping.
>
> I think this is almost ready, it would be great to get the last remaining comments with respect to wording & tests wrapped up.
>
> If you won't be able to follow up on this, it would be great if you could let us know, so potentially someone else could pick it up.

Sorry, still in a busy time.

I switched the name of the function to `eliminateRedundantStoresOfExisitingValues`. When I reverted my changes in some of the test files, one test now fails unexpectedly. The only reason those changed was because I ran that python script to update the tests.

For the additional tests, if someone else would like to pick that up, I am more than happy to go with that. I am not as well versed with my LLVM IR as many of you are :-).

Sorry about the slowness of this. I was planning on having it wrapped up weeks ago.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90328/new/

https://reviews.llvm.org/D90328



More information about the llvm-commits mailing list