[PATCH] D94613: [NFC] Rename ThinLTOPhase to PhaseInAllLTO and move it from PassBuilder.h to Pass.h

Wed Jan 13 11:49:25 PST 2021

davidxl added inline comments.

================
Comment at: llvm/include/llvm/Pass.h:75
+/// This enumerates the LLVM LTO or ThinLTO optimization phases.
+enum class PhaseInAllLTO {
+  /// No LTO/ThinLTO behavior needed.
----------------
wenlei wrote:
> nit: name it `LTOPhase`? There's similar change in https://reviews.llvm.org/D69732. 
> 
> And perhaps FullLTOPreLink and FullLTOPostLink too though I noticed there's PrepareForLTO and PrepareForThinLTO.. Not sure if LTO is always used to refer FullLTO..
LTO traditionally refers to FullLTO, so using LTO can be confusing.

I suggest make it even clearer:

ThinOrFullLTOPhase

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94613/new/

https://reviews.llvm.org/D94613