[PATCH] D94613: [NFC] Rename ThinLTOPhase to PhaseInAllLTO and move it from PassBuilder.h to Pass.h

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

Thanks for refactoring. We had internal change to add `IsFullLTOPreLink` alongside with `IsThinLTOPreLink` for a few places. And we always wanted clean it up too. :)



================
Comment at: llvm/include/llvm/Pass.h:75
+/// This enumerates the LLVM LTO or ThinLTO optimization phases.
+enum class PhaseInAllLTO {
+  /// No LTO/ThinLTO behavior needed.
----------------
nit: name it `LTOPhase`? There's similar change in https://reviews.llvm.org/D69732. 

And perhaps FullLTOPreLink and FullLTOPostLink too though I noticed there's PrepareForLTO and PrepareForThinLTO.. Not sure if LTO is always used to refer FullLTO..


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94613/new/

https://reviews.llvm.org/D94613