[PATCH] D94595: [Support] Simplify KnownBits::icmp helpers. NFC.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 13 08:24:12 PST 2021
RKSimon added inline comments.
================
Comment at: llvm/lib/Support/KnownBits.cpp:273
if (LHS.isConstant() && RHS.isConstant())
return Optional<bool>(LHS.getConstant() == RHS.getConstant());
if (LHS.One.intersects(RHS.Zero) || RHS.One.intersects(LHS.Zero))
----------------
foad wrote:
> RKSimon wrote:
> > Is this still worth keeping?
> Yes, it's the only way we can ever return true.
eek - sorry about that!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94595/new/
https://reviews.llvm.org/D94595
More information about the llvm-commits
mailing list