[PATCH] D94595: [Support] Simplify KnownBits::icmp helpers. NFC.

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Support/KnownBits.cpp:273
   if (LHS.isConstant() && RHS.isConstant())
     return Optional<bool>(LHS.getConstant() == RHS.getConstant());
   if (LHS.One.intersects(RHS.Zero) || RHS.One.intersects(LHS.Zero))
----------------
RKSimon wrote:
> Is this still worth keeping?
Yes, it's the only way we can ever return true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94595/new/

https://reviews.llvm.org/D94595