[PATCH] D94494: canCreateUndefOrPoison: dyn_cast -> dyn_cast_or_null

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 16:44:19 PST 2021


aqjune added a comment.

Thanks!
Yes, a test should be added.
I guess

  ashr <4 x i16> %induction, select (i1 icmp sgt (i16 ptrtoint (i16* @c to i16), i16 1), <4 x i16> zeroinitializer, <4 x i16> <i16 ptrtoint (i16* @c to i16), i16 ptrtoint (i16* @c to i16), i16 ptrtoint (i16* @c to i16), i16 ptrtoint (i16* @c to i16)>)

is the problematic part?
If it is non-trivial to further reduce the input, you can also add this instruction to the list at ValueTrackingTest.cpp 's `TEST(ValueTracking, canCreatePoisonOrUndef)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94494/new/

https://reviews.llvm.org/D94494



More information about the llvm-commits mailing list