[PATCH] D94494: canCreateUndefOrPoison: dyn_cast -> dyn_cast_or_null

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D94494#2493719 <https://reviews.llvm.org/D94494#2493719>, @dblaikie wrote:

> In D94494#2492801 <https://reviews.llvm.org/D94494#2492801>, @markus wrote:
>
>> F15010211: bbi-51646.ll <https://reviews.llvm.org/F15010211>
>>
>> The issue was found with attached input bbi-51646.ll If necessary it could be added as a regression test but then the question is where (i.e. should it piggyback on some other file).
>
> Probably just in its own file (we don't do a very good job of keeping a lot of related tests in a single file together - usually just add more files, it's not ideal but often hard to find other good groupings) - but if you're looking for related test files, try breaking the pass in some obvious way

Such as adding `assert(false)` in the codepath you're experimenting with, etc.

> and see what tests fail - that should help you find some related tests that could be piggy backed on.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94494/new/

https://reviews.llvm.org/D94494