[PATCH] D94470: [LSR] Don't break a critical edge if parent ends with "callbr"

Tue Jan 12 14:00:32 PST 2021

void added a comment.

In D94470#2494271 <https://reviews.llvm.org/D94470#2494271>, @MaskRay wrote:

> In D94470#2493961 <https://reviews.llvm.org/D94470#2493961>, @void wrote:
>
>> In D94470#2493295 <https://reviews.llvm.org/D94470#2493295>, @MaskRay wrote:
>>
>>> The test should be added in `test/Transforms/PGOProfile/`, see D87435 <https://reviews.llvm.org/D87435>
>>
>> The error isn't in `opt` but in `llc` though. In fact, I don't think it's specific to PGO, but only triggered by it.
>
> Then it should be in `llvm/test/Transforms/LoopStrengthReduce/`

This is a code-gen bug. I'm not sure how else to put this. If I run it through opt, it doesn't reproduce.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94470/new/

https://reviews.llvm.org/D94470