[PATCH] D94470: [LSR] Don't break a critical edge if parent ends with "callbr"
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 12 13:46:27 PST 2021
MaskRay added inline comments.
================
Comment at: llvm/test/CodeGen/Generic/callbr-critical-edge-splitting.ll:1
+; RUN: llc < %s -o /dev/null
+
----------------
Can you write a `opt -passes='loop(loop-reduce)' ` test?
Checking a command returns 0 is not a useful test. Checking some desired instructions makes the test not only useful for one particular regression, but also useful for some other scenarios.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94470/new/
https://reviews.llvm.org/D94470
More information about the llvm-commits
mailing list