[PATCH] D94536: [dsymutil] Warn on timestmap mismatch between object file and debug map

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: llvm/tools/dsymutil/BinaryHolder.cpp:103
+      return errorCodeToError(Stat.getError());
+    if (Timestamp != Stat->getLastModificationTime())
+      WithColor::warning() << Filename
----------------
aprantl wrote:
> If I'm reading this right, we are warning for archive members (where the timestamp is used to disambiguate between same-named objects in different slices) only in verbose mode and here always? I would have expected it to be the other way round or at least consistent between the two.
An archive can contain multiple files with the same name but different timestamps. If we don't find a perfect match, we'll error out (see the `continue` on line 202), so this is actually a stronger requirement than for object and swift interface files, where we'll print the warning but use the file regardless. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94536/new/

https://reviews.llvm.org/D94536