[PATCH] D94536: [dsymutil] Warn on timestmap mismatch between object file and debug map

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 11:37:31 PST 2021


aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/BinaryHolder.cpp:103
+      return errorCodeToError(Stat.getError());
+    if (Timestamp != Stat->getLastModificationTime())
+      WithColor::warning() << Filename
----------------
If I'm reading this right, we are warning for archive members (where the timestamp is used to disambiguate between same-named objects in different slices) only in verbose mode and here always? I would have expected it to be the other way round or at least consistent between the two.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94536/new/

https://reviews.llvm.org/D94536



More information about the llvm-commits mailing list