[PATCH] D93710: [mlir][openacc] Use TableGen information for default enum

Mon Jan 11 18:06:14 PST 2021

clementval added a comment.

In D93710#2491433 <https://reviews.llvm.org/D93710#2491433>, @kiranchandramohan wrote:

> Thanks for the patience.
>
> LGTM. One comment regarding doc generation before I approve.
>
> Mehdi added a patch to OpenMP dialectCMake for building the Doc generation for the OpenMP dialect otherwise a bot will fail. I guess it is needed in the OpenACC CMake as well.
> https://reviews.llvm.org/rG7b18716361a533023d7f5366add759038c8a7825

Thanks for the review. I saw it in the OpenMP CMakeLists.txt and I thought it was a bit weird to add dependency to the doc but make sense with the linked patch. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93710/new/

https://reviews.llvm.org/D93710