[PATCH] D93710: [mlir][openacc] Use TableGen information for default enum

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 14:33:10 PST 2021


kiranchandramohan added a comment.

Thanks for the patience.

LGTM. One comment regarding doc generation before I approve.

Mehdi added a patch to OpenMP dialectCMake for building the Doc generation for the OpenMP dialect otherwise a bot will fail. I guess it is needed in the OpenACC CMake as well.
https://reviews.llvm.org/rG7b18716361a533023d7f5366add759038c8a7825


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93710/new/

https://reviews.llvm.org/D93710



More information about the llvm-commits mailing list