[PATCH] D94385: [NFC] Disallow unused prefixes in CodeGen/PowerPC tests.

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 07:11:17 PST 2021


nemanjai accepted this revision.
nemanjai added a comment.

Thanks for doing this. I think it is useful for test cases to fail if a check prefix is unused (or becomes unused). LGTM.



================
Comment at: llvm/test/CodeGen/PowerPC/testComparesigeus.ll:5
 ; RUN:  --implicit-check-not cmpw --implicit-check-not cmpd --implicit-check-not cmpl \
-; RUN:  --check-prefixes=CHECK,BE
+; RUN:
 ; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu -O2 \
----------------
I imagine this was done by a script that ended up leaving these behind, but can you please remove empty `RUN:` lines?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94385/new/

https://reviews.llvm.org/D94385



More information about the llvm-commits mailing list