[PATCH] D94385: [NFC] Disallow unused prefixes in CodeGen/PowerPC tests.

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 06:53:02 PST 2021


jsji accepted this revision as: jsji.
jsji added a comment.
This revision is now accepted and ready to land.

LGTM , thanks for cleaning up .



================
Comment at: llvm/test/CodeGen/PowerPC/ppc32-pic.ll:4
 ; RUN: llc < %s -mtriple=powerpc -relocation-model=pic -mattr=+secure-plt | \
-; RUN:    FileCheck -check-prefixes=SMALL,SMALL-SECUREPLT %s
 @bar = common global i32 0, align 4
----------------
Looks like this is typo, should be `SMALL-SECURE` instead of `SMALL-SECUREPLT`.


================
Comment at: llvm/test/CodeGen/PowerPC/ppc32-pic.ll:4
 ; RUN: llc < %s -mtriple=powerpc -relocation-model=pic -mattr=+secure-plt | \
-; RUN:    FileCheck -check-prefixes=SMALL,SMALL-SECUREPLT %s
+; RUN:    FileCheck --check-prefix=SMALL %s
 @bar = common global i32 0, align 4
----------------
jsji wrote:
> Looks like this is typo, should be `SMALL-SECURE` instead of `SMALL-SECUREPLT`.
Maybe update it to `SMALL-SECURE` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94385/new/

https://reviews.llvm.org/D94385



More information about the llvm-commits mailing list