[PATCH] D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize

[Tobias Burnus via Phabricator via llvm-commits]

burnus added a comment.

@MaskRay: See previous comment. It is not clear to me which GCC changes you think are required and what you mean by "ifndef BUILTIN" (i.e. why it is needed to test for).

I do see why  a section name with ".rodata" and no flags would give different results with different assemblers, which might be unfortunate. But it is preexisting and unchanged by this patch.
I also do not see how this relates to the issue at hand, this patch, or GCC (which does outputs the SHF_ALLOC flag for the first output of a .rodata section).

Hence, from my part the attached patch is still fine – except that clang-format does not like the preexisting variable name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94072/new/

https://reviews.llvm.org/D94072