[PATCH] D54749: Saturating float to int casts.

Mon Jan 11 06:27:12 PST 2021

bjope added a comment.

In D54749#2489043 <https://reviews.llvm.org/D54749#2489043>, @nikic wrote:

> @bjope There are two more revisions based on this one, D86079 <https://reviews.llvm.org/D86079> implements improved X86 lowerings and is already accepted, and D86078 <https://reviews.llvm.org/D86078> implements improved AArch64 lowerings. Do you plan to land these as well?

My plan has been to move forward with D86632 <https://reviews.llvm.org/D86632> (which is ready to land and makes use of the new intrisics for conversions between fixed point and floating point).
And then also to land the patch that improves lowering for X86 (D86079 <https://reviews.llvm.org/D86079>) as it has been accepted.

I haven't looked closely at the patch that improves lowering for AArch64 (D86078 <https://reviews.llvm.org/D86078>). I need to figure out if there are any review comments that haven't been addressed yet. If it ends up being within my comfort zone I'll try to move forward with that patch as well :-)   I'll at least make sure there is some kind of status update to that patch as I don't think we can't rely on Bevin picking it up again soon.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54749/new/

https://reviews.llvm.org/D54749