[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 19:35:54 PST 2021


mtrofin added a comment.

In D94333#2488359 <https://reviews.llvm.org/D94333#2488359>, @davidxl wrote:

> Should we get rid of DefaultInlineAdvice and fold it into the base class InlineAdvice?   'DefaultInlineAdvice' implies it is an advice provided by the default advisor which no longer is true.
>
> Besides the inlineAdvice contains a reference to the inlineAdvisor, so where the advice comes from is discoverable.
>
> @mtrofin

I can look into it, we need to look at its uses on the ML side.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94333/new/

https://reviews.llvm.org/D94333



More information about the llvm-commits mailing list