[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 19:31:24 PST 2021


davidxl added a comment.

Should we get rid of DefaultInlineAdvice and fold it into the base class InlineAdvice?   'DefaultInlineAdvice' implies it is an advice provided by the default advisor which no longer is true.

Besides the inlineAdvice contains a reference to the inlineAdvisor, so where the advice comes from is discoverable.

@mtrofin


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94333/new/

https://reviews.llvm.org/D94333



More information about the llvm-commits mailing list