[PATCH] D94037: [WebAssembly] Change label numbers to variables in test

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.ll:440
-; fix this by wrapping the call with a nested try/catch/end_try and branching to
-; the right destination (label4), from which we rethrow the exception to the
-; caller.
----------------
tlively wrote:
> This should have been `label35` rather than `label4` previously, right?
Yes, the comment looks stale already. Hope this CL prevents something like this in future...


================
Comment at: llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.ll:581
 ; signature). Here the two calls two 'bar' are supposed to throw up to the
-; caller, but incorrectly unwind to 'catch19' after linearizing the CFG.
 
----------------
tlively wrote:
> And `catch19` should have been `catch23`?
Yes here too. These numbers changed whenever I added a test in the middle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94037/new/

https://reviews.llvm.org/D94037