[PATCH] D94037: [WebAssembly] Change label numbers to variables in test

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 10:22:24 PST 2021


tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

Looks good! A few of the replacements in the code don't match the replacements in the comments, but I assume the comments were previously just stale.



================
Comment at: llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.ll:440
-; fix this by wrapping the call with a nested try/catch/end_try and branching to
-; the right destination (label4), from which we rethrow the exception to the
-; caller.
----------------
This should have been `label35` rather than `label4` previously, right?


================
Comment at: llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.ll:581
 ; signature). Here the two calls two 'bar' are supposed to throw up to the
-; caller, but incorrectly unwind to 'catch19' after linearizing the CFG.
 
----------------
And `catch19` should have been `catch23`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94037/new/

https://reviews.llvm.org/D94037



More information about the llvm-commits mailing list