[PATCH] D94250: [SystemZ] Introducing assembler dialects for the Z backend

Anirudh Prasad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 11:26:38 PST 2021


anirudhp created this revision.
anirudhp added reviewers: Kai, yusra.syeda, uweigand, jnspaulsson.
Herald added a subscriber: hiraditya.
anirudhp requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

- This patch introduces a different assembler dialect ("hlasm") for z/OS. The default dialect has now been given the "att" dialect name. For this appropriate changes have been added to SystemZ.td.
- This patch also makes a few changes to SystemZInstrFormats.td which restrict a few condition code mnemonics to just the "att" dialect variant (he, le, lh, nhe, nle, nlh). These extended condition code mnemonics are not available in HLASM.
- A new private function has been introduced in SystemZAsmParser.cpp to return the assembler dialect set in SystemZMCAsmInfo.cpp. The reason we couldn't/haven't explicitly queried the overriden getAssemblerDialect function from AsmParser is outlined in this thread here <https://lists.llvm.org/pipermail/llvm-dev/2020-November/146875.html>. This returned dialect is directly passed onto the relevant matcher functions which taken in a variantID, so that the matcher functions can appropriately choose an instruction based on the variant.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94250

Files:
  llvm/lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp
  llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCAsmInfo.cpp
  llvm/lib/Target/SystemZ/SystemZ.td
  llvm/lib/Target/SystemZ/SystemZInstrFormats.td
  llvm/lib/Target/SystemZ/SystemZInstrInfo.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94250.315188.patch
Type: text/x-patch
Size: 14503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210107/6d2e025e/attachment-0001.bin>


More information about the llvm-commits mailing list