[PATCH] D94223: [SelectionDAG] Extend immAll(Ones|Zeros)V to handle ISD::SPLAT_VECTOR

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 04:04:32 PST 2021


frasercrmck added a comment.

In D94223#2484023 <https://reviews.llvm.org/D94223#2484023>, @lebedev.ri wrote:

> This seems to be missing test coverage.

The functionality is tested in part by replacing `riscv_m_vnot` with `vnot` and having the patterns still match. I've just identified that there are two further RVV patterns which can potentially be updated to use `immAllOnesV` and `immAllZeroV` and will try that out accordingly.

But I would gladly add more testing (for more targets) if someone can help me find a way in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94223/new/

https://reviews.llvm.org/D94223



More information about the llvm-commits mailing list