[PATCH] D94140: [WebAssembly] Fixed byval args missing DWARF DW_AT_LOCATION

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 14:32:31 PST 2021


aprantl added a comment.

Mechanically this LGTM.



================
Comment at: llvm/test/CodeGen/WebAssembly/dbgvalue.ll:4
 ; CHECK: %bb.0
-; CHECK: #DEBUG_VALUE: usage:self <- %4
+; CHECK: #DEBUG_VALUE: usage:self <- !target-index(0,0)
 ; CHECK: %bb.1
----------------
it would be nicer if we piped the output to llvm-dwarfdump and CHECK that output rather than checking for a comment in the assembler output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94140/new/

https://reviews.llvm.org/D94140



More information about the llvm-commits mailing list