[PATCH] D94140: [WebAssembly] Fixed byval args missing DWARF DW_AT_LOCATION

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a subscriber: aprantl.
dblaikie added a comment.

In D94140#2480989 <https://reviews.llvm.org/D94140#2480989>, @aardappel wrote:

> @dblaikie Added you for review since this modifies common DWARF code, would love to hear if that is problematic or not. It would seem not, since we're the only users of these TI's it seems, and the new code is generic enough that it could work for future targets using TIs?

Yeah, since you folks are the ones that are using this feature for now (I guess/can you confirm that the TI things were added specifically for WebAssembly?) it's pretty much up to you. For more nuanced review of debug info locations, @aprantl is probably a more useful reference point - the actual optimized debug info variable location tracking, etc, isn't something I've stayed particularly close to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94140/new/

https://reviews.llvm.org/D94140